Skip to content
This repository was archived by the owner on Sep 4, 2019. It is now read-only.

Escaped double quotes for pim.contacts#644

Open
DanielAudino wants to merge 1 commit into
blackberry:nextfrom
blackberry-webworks:next-contacts-specialChar
Open

Escaped double quotes for pim.contacts#644
DanielAudino wants to merge 1 commit into
blackberry:nextfrom
blackberry-webworks:next-contacts-specialChar

Conversation

@DanielAudino

Copy link
Copy Markdown

To remove error when finding a contact that contains special characters

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this make more sense as a regexp? This seems ugly.

@rwmtse

rwmtse commented Apr 1, 2013

Copy link
Copy Markdown
Contributor

@cdelcol

cdelcol commented Apr 1, 2013

Copy link
Copy Markdown
Contributor

Any chance that it is related?
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=308748

@rwmtse

rwmtse commented Apr 1, 2013

Copy link
Copy Markdown
Contributor

@cdelcol It is

@cdelcol

cdelcol commented Apr 1, 2013

Copy link
Copy Markdown
Contributor

@rwmtse you beat me to it :) i'll update the PR.

@ejzn

ejzn commented Apr 11, 2013

Copy link
Copy Markdown
Contributor

@DanielAudino @rwmtse Are we putting this into the Cordova branch of things....?

@bryanhiggins

Copy link
Copy Markdown
Contributor

Thanks for catching that @erikjohnzon

This needs to go into cordova-blackberry-plugins otherwise no one will get in unless they're building from the GitHub repo.

@EricLeiLi please make sure this is carried into the core plugin as well if necessary

@cdelcol

cdelcol commented Apr 24, 2013

Copy link
Copy Markdown
Contributor

@EricLeiLi @haahmad did this change get into the new repos? can someone update the PR?

https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=308748

cc @grahamzibar

@haahmad

haahmad commented Apr 24, 2013

Copy link
Copy Markdown
Contributor

@cdelcol No, it has not. I will open a pull request into cordova-blackberry-plugins, then use the newly built so file for pim.contacts and the cordova contacts plugins

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants