Turn Luau into a shared library, make sure all of the libraries are moved correctly - #944
Open
TylkoKuba wants to merge 3 commits into
Open
Turn Luau into a shared library, make sure all of the libraries are moved correctly#944TylkoKuba wants to merge 3 commits into
TylkoKuba wants to merge 3 commits into
Conversation
Owner
|
Sorry this fell through the cracks so long. Current status: I think this is a good change, I was just annoyed that Luau creates so many libraries when you tell it to build shared libraries. I tried to get Luau's CMake to produce 1 library file but didn't have any luck, might need to modify lovr's fork to do it. But still, it's kind of a separate issue from the fix here, so I should probably merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luau was not built as a shared library, as a result all the plugins instead of linking against it were building against it, additionally move_lib and move_dll function had to be changed as Luau is composed of "Luau.VM", "Luau.Compiler", "Luau.Ast" and "Luau.Common" (which was missing, but seems to be required). I've discovered that when trying to use enet together with Luau version of Lovr which now functions properly :)