[AC-1615] [GSuite] Resolve conflicts using timestamps - #350
Open
hwyss-anybotics wants to merge 2 commits into
Open
[AC-1615] [GSuite] Resolve conflicts using timestamps#350hwyss-anybotics wants to merge 2 commits into
hwyss-anybotics wants to merge 2 commits into
Conversation
When we check for duplicate emails, it's entirely possible that there are valid instances of this (e.g. a user has been repeatedly created and deleted, and finally created anew). This changeset introduces the timestamp data provided by GSuite (specifically creation and deletion date), and applies the following heuristics: - if a user was deleted before another one with the same Email address was created, then it can be ignored, and no duplicate email error need be raised - if multiple users with the same email address were all deleted, we can safely synchronize that deletion. - if a user has been deleted after the creation of a user with a conflicting email address, we still raise a duplicate email error.
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we check for duplicate emails, it's entirely possible that there are valid instances of this (e.g. a user has been repeatedly created and deleted, and finally created anew).
This changeset introduces the timestamp data provided by GSuite (specifically creation and deletion date), and applies the following heuristics:
Type of change
Objective
We currently cannot synchronize our Google Workspace with Bitwarden, because the duplicate detection chokes on one (or more?) users that have been repeatedly created, deleted, and recreated again.
Code changes
Screenshots
Testing requirements
Before you submit
npm run lint) (required)