[PS-1239] If a group name is too long, shorten it to 100 characters - #277
Open
hajekj wants to merge 3 commits into
Open
[PS-1239] If a group name is too long, shorten it to 100 characters#277hajekj wants to merge 3 commits into
hajekj wants to merge 3 commits into
Conversation
Contributor
Author
|
@vgrassia could somebody look into this PR please? |
|
Hi @hajekj , thank you for opening this PR. This has been added to our internal board for review. We'd get back to you with our feedback and/or concerns. Very appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
When a group originating from Azure AD has more than 100 characters in its name, the entire import will fail. This PR shortens every group name to the maximum of 100 characters to make sure the import passes.
Code changes
Testing requirements
N/A, bugfix.
Before you submit
npm run lint) (required)