add thesis page and sample projects - #32
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe thesis content is moved into a generic ChangesStatic Markdown Pages
Sequence Diagram(s)sequenceDiagram
participant Build as Astro build
participant Collection as pages collection
participant Route as [slug].astro
participant Layout as BaseLayout
Build->>Collection: Load pages entries
Collection->>Route: Map entry IDs to slug routes
Route->>Route: Render page content
Route->>Layout: Pass rendered content and title
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* removed individual thesis projects; simplified thesis thesis.astro to a markdown page in content/pages/thesis.md * Updated thesis page to start each sentence on a new line
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/[slug].astro (1)
13-14: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider typing
Astro.propsfor better TypeScript support.Since the repository uses TypeScript strict mode, you can explicitly type
Astro.propsby inferring it fromgetStaticPaths. This ensures that thepageprop and its data are correctly typed within the component. As per coding guidelines, TypeScript strict mode should be utilized for.astrofiles.💡 Proposed refactor
-const { page } = Astro.props; +import type { InferGetStaticPropsType } from 'astro'; + +type Props = InferGetStaticPropsType<typeof getStaticPaths>; + +const { page } = Astro.props as Props;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/`[slug].astro around lines 13 - 14, Type the Astro.props destructuring in the page component using the prop type inferred from getStaticPaths, so page and its data are checked under strict TypeScript rules while preserving the existing render(page) flow.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/pages/`[slug].astro:
- Around line 13-14: Type the Astro.props destructuring in the page component
using the prop type inferred from getStaticPaths, so page and its data are
checked under strict TypeScript rules while preserving the existing render(page)
flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 632bf13a-44bd-4cb8-ba4c-f1962eb44d64
📒 Files selected for processing (7)
CLAUDE.mdREADME.mdsrc/content.config.tssrc/content/pages/thesis.mdsrc/pages/[slug].astrosrc/pages/thesis.astrosrc/styles/global.scss
💤 Files with no reviewable changes (1)
- src/pages/thesis.astro
What does this PR change?
Checklist
npm run format:checkpasses (or runnpm run formatto auto-fix)npm run lintpassesnpm run buildsucceeds locallypublic/profile-images/(if applicable)src/data/publications.bib(if applicable)Summary by CodeRabbit