ARGS: defaults is now always interpreted as a list#29
Merged
Conversation
andresailer
reviewed
Oct 22, 2025
andresailer
reviewed
Oct 22, 2025
andresailer
reviewed
Oct 22, 2025
| continue | ||
| skip = False | ||
| for d in defaults: | ||
| if p == "defaults-release" and ("defaults-" + d) in specs: |
Collaborator
There was a problem hiding this comment.
Also here: not clear what the point of (e.g.) defaults-lcg in specs is, since this is not going to have all the defaults in specs eventually.
I guess more of a question for @pbuncic.
Ni-Langguth
force-pushed
the
support-more-defaults
branch
from
October 22, 2025 16:06
2f28233 to
c54f0c6
Compare
andresailer
reviewed
Oct 24, 2025
andresailer
reviewed
Nov 4, 2025
| # Latest package built for a given devel prefix gets latest-$BUILD_FAMILY | ||
| if [[ $BUILD_FAMILY ]]; then | ||
| ln -snf $PKGVERSION-$PKGREVISION $ARCHITECTURE/$PKGNAME/latest-$BUILD_FAMILY | ||
| for DEFAULT in $BUILD_FAMILY; do |
Collaborator
There was a problem hiding this comment.
I think this change would not be needed with #31 , because then BUILD_FAMILY is a string again, and the defaults are "_" joined.
Ni-Langguth
marked this pull request as draft
November 6, 2025 15:12
Ni-Langguth
force-pushed
the
support-more-defaults
branch
4 times, most recently
from
November 7, 2025 16:34
3f209b9 to
75bfbcb
Compare
Ni-Langguth
marked this pull request as ready for review
November 7, 2025 21:47
Ni-Langguth
force-pushed
the
support-more-defaults
branch
2 times, most recently
from
November 12, 2025 08:16
308006c to
ace8637
Compare
Ni-Langguth
marked this pull request as draft
November 12, 2025 08:17
added 7 commits
November 12, 2025 16:51
…, adjusts for str->list
Ni-Langguth
force-pushed
the
support-more-defaults
branch
from
November 12, 2025 15:53
ace8637 to
886170c
Compare
Ni-Langguth
marked this pull request as ready for review
November 12, 2025 15:55
Contributor
|
OK, I'll merge this but tests should be all fixed if they are still failing. |
Author
|
Well, the tests are failing because of changes in the main branch, not in shahzads or mine. Of course they should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, an infinite number of defaults can be concatenated with :: and applied to a build.