Message bus auth and jakarta - #4
Open
Asger-KB wants to merge 3 commits into
Open
Conversation
ole-v-v
reviewed
Jul 29, 2026
Comment on lines
+201
to
+214
| <xs:element name="Username" type="xs:string" minOccurs="0"> | ||
| <xs:annotation> | ||
| <xs:documentation xml:lang="en"> | ||
| Username to connect to the message bus. Optional. | ||
| </xs:documentation> | ||
| </xs:annotation> | ||
| </xs:element> | ||
| <xs:element name="Password" type="xs:string" minOccurs="0"> | ||
| <xs:annotation> | ||
| <xs:documentation xml:lang="en"> | ||
| Password to connect to the message bus. Optional | ||
| </xs:documentation> | ||
| </xs:annotation> | ||
| </xs:element> |
Contributor
There was a problem hiding this comment.
If I understand correctly, we are modifying the production settings format for the sake of our tests. How strong arguments do we need for that? Could test settings go somewhere else?
ole-v-v
reviewed
Jul 29, 2026
Contributor
There was a problem hiding this comment.
I restored the indentation of this file. My IntelliJ IDEA prefers it this way, and it agrees with the indentation of the other pom.xml files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.