Bev 718 test i bitmagasinets referencekode - #92
Conversation
…lass declared with a non-serializable type" by not making the autogenerated types serializable
ole-v-v
left a comment
ole-v-v
left a comment
There was a problem hiding this comment.
This pull request fulfils a wish we have had for a longer time and contains a wealth of improvements, big and small.
The pull request contains a few incompatible changes mentioned in my comments. I believe we want to avoid them for now.
88 source files still mention Derby. We may want to reduce that number and/or create a task to get rid of the mentions.
I have not understood how we can do without the configuration of the allure-maven plugin. Since tests pass, I trust that we can.
Please read through my comments on bigger and (many) small issues and make appropriate changes.
Nice work.
| <artifactId>jakarta.xml.bind-api</artifactId> | ||
| <version>2.3.3</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/jakarta.activation/jakarta.activation-api --> |
There was a problem hiding this comment.
Why not keep this comment and the next one?
| <message.xml.version>33-SNAPSHOT</message.xml.version> | ||
| <repository.settings.version>15-SNAPSHOT</repository.settings.version> |
There was a problem hiding this comment.
Are we happy with snapshot versions??
There was a problem hiding this comment.
No, they should be released before merging this
| <configuration> | ||
| <rules> | ||
| <requireMavenVersion> | ||
| <version>3.9.1</version> |
There was a problem hiding this comment.
We may want to go on Maven 4 at a point (please keep it out of this pull request).
There was a problem hiding this comment.
4 is not released yet
2 participants
Skift til java 21
Skift til Jakarta
Skift til Artemis
Skift til TestContainers
Alle tests virker
Cleaned up compiler warnings