Skip to content

[WIP] Remove foldable decorator from codebase#4

Closed
bitifet with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-foldable-decorator
Closed

[WIP] Remove foldable decorator from codebase#4
bitifet with Copilot wants to merge 1 commit into
mainfrom
copilot/remove-foldable-decorator

Conversation

Copilot AI commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Look at the "foldable" decorator.

Analyze how it works and its use case and tell me if it makes sense in the context of Smarkform's philosophy.

It's an ancient part of SmarkForm but I'm not sure if it really makes sense…

I reckon same behaviour can be, at least nowadays, done by simply using details and summary httml tags.

Furthermore, the summary tag could include fields showing part of the inner form (for instance using a details tag as list items so that each item of the list can easily be identified by an always visible field.

If you agree with me and see no issues, we could remove it from the codebase taking care to propperly update examples that use it.

Documentation should be also updated removing the references to the related "foldable" property.

Even we may probably add an example (or update some existing one…) to the Showcase section of the documentation showing the same functionality using just the native details and summary tags.

Please, tell me your thoughts and ask me any question you could have and, if we agree in everything you could proceed to create a new pull request to implement the changes.

Copilot AI requested a review from bitifet April 6, 2026 01:22
Copilot stopped work on behalf of bitifet due to an error April 6, 2026 01:22
@bitifet bitifet closed this Apr 6, 2026
@bitifet

bitifet commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Sent to the wrong repository from mobile interface

@bitifet bitifet deleted the copilot/remove-foldable-decorator branch April 6, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants