bdshemu: Fix MOVS/STOS/LODS/SCAS/CMPS silent no-op at MaxInstructionsCount boundary#116
Merged
vlutas merged 1 commit intoJun 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MOVS/STOS/LODS/SCAS/CMPS handlers gate their body on:
while (Context->InstructionsCount < Context->MaxInstructionsCount),but the outer dispatch loop has already incremented
InstructionsCountto the slot it spent on this dispatch. When those values are equal at that moment (e.g. whenMaxInstructionsCount == 1), the body is skipped entirely andShemuEmulatereturnsSHEMU_SUCCESSwith no memory move, no RSI/RDI advance, no RCX decrement, and no flag update.Switched both handlers to
do { ... } while (...)so the firstiteration always runs.