BIP376: keep PSBT_IN_WITNESS_UTXO after finalization - #2276
Open
bitsagarob wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP 174 says the Input Finalizer keeps the UTXO so the Transaction Extractor can verify the final transaction, and its finalized example PSBT does keep it. This BIP's Finalizer section requires removing PSBT_IN_WITNESS_UTXO. None of the finalizers I checked do that: Core's FinalizePSBT, Sparrow's clearNonFinalFields, rust-psbt's Input::finalize and rust-miniscript all keep it. Removing it also breaks partially finalized PSBTs: BIP 341 sighashes commit to every spent output, so once one input is finalized this way no remaining taproot input can be signed (Core's PrecomputePSBTData fails without all UTXOs).