File data meta gzip generic#8
Open
shadders wants to merge 5 commits into
Open
Conversation
ryanxcharles
approved these changes
Jan 28, 2019
so i get credit in the commit history
fix my own name
Closed
Contributor
|
can you merge this so we can start issuing new PRs? i have a new protocol to add and i think it would be best to merge against the main repo instead of against your PR. |
kyuupichan
reviewed
Feb 4, 2019
|
|
||
| The protocol identfier is a `PUSHDATA` data element `0x04 0x6d657461` which is the 1 byte length prefix followed by the 4 byte identifier which translates to the ASCII string `meta`. | ||
|
|
||
| This should be followed by a further `PUSHDATA` data element: `<metadate>` which is a a JSON encoded set of the key value pairs. The key value pairs remain unspecified. |
There was a problem hiding this comment.
Typos: "metadate", "a a". Should be mentioned the data is UTF-8 encoded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated from pr # 5
Generic 'file' protocol based on Ryan X Charles' proposal.
Generic 'data' protocol
'meta' protocol for marking up other protocols with JSON meta data
'gzip' protocol for compressing data elements in any other data element based protocol.