test: add map serialization round-trip coverage#297
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsNo conflicts as of last run. |
8d86060 to
645d90b
Compare
|
Forced-push 645d90b to include map on test.cpp for IWYU |
|
Concept ACK |
|
Looks clean to me, tACK 645d90b |
| message @0 :Text; | ||
| } | ||
|
|
||
| struct Pair(T1, T2) { |
There was a problem hiding this comment.
In commit "test: drop mapSize, now covered by map round-trip test" (490585f)
I'm not really a fan the commit dropping the mapsize test. It seem to me the generic Pair() type is good to keep because it could be used in other tests testing non-primitive maps, and also it makes helps make sure the code generator and library code works with generics in capnproto, not just non-generic types.
I also don't love renumbering the passDouble method. It seems a little cleaner to me to either fully follow the compatibility rules for updating schema files, or fully not follow them and just update all the field numbers to match field order. It doesn't seem like there is a rationale for numbering fields out of order and also not following compatibility rules.
There was a problem hiding this comment.
Good points, dropped the commit "test: drop mapSize, now covered by map round-trip test" 490585f. OBS: I still kept the StringIntPair because only pointer types (structs, lists, blobs, and interfaces) can be used as generic parameters.
645d90b to
463d073
Compare
Add test to ensure map serialization is working and will keep working. Useful for #285.
Also renames
v_booltovector_bool.Best reviewed commit by commit.