nl_vxlan: always pass bridge interface to ::create_endpoint() - #481
Merged
Conversation
KanjiMonster
force-pushed
the
jogo_fix_vxlan_endpoint_bridge_attachment
branch
from
August 14, 2025 07:13
dc2e743 to
d322af3
Compare
When nl_vlxan::create_endpoint(rtnl_link *) is called, it has no br_link, it calls nl_vlxan::create_endpoint(rtnl_link *, rtnl_link *, nl_addr *) with a nullptr for the bridge interface. This causes it to not add the endpoint to the l2 overlay group, breaking connectivity. Since we only ever call nl_vlxan::create_endpoint(rtnl_link *) from places where we know a br_link exists, add it to the arguments. Should fix spurious failures of the vxlan-bridge tests in our testing pipelines. Fixes: ec8902a ("cnetlink::link_created(): call vxlan::create_endpoint() later") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_fix_vxlan_endpoint_bridge_attachment
branch
from
August 15, 2025 08:32
d322af3 to
73ffbf3
Compare
KanjiMonster
marked this pull request as ready for review
August 15, 2025 09:34
Contributor
Author
|
Weekend pipelines have run with this change applied, and no further vxlan test failures occured. |
rubensfig
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When nl_vlxan::create_endpoint(rtnl_link *) is called, it has no br_link, it calls nl_vlxan::create_endpoint(rtnl_link *, rtnl_link *, nl_addr *) with a nullptr for the bridge interface.
This causes it to not add the endpoint to the l2 overlay group, breaking connectivity.
Since we only ever call nl_vlxan::create_endpoint(rtnl_link *) from places where we know a br_link exists, add it to the arguments.
Should fix spurious failures of the vxlan-bridge tests in our testing pipelines.
Fixes: ec8902a ("cnetlink::link_created(): call vxlan::create_endpoint() later")