set rx rate to unlimited for knet - #450
Merged
Merged
Conversation
KanjiMonster
force-pushed
the
jogo_set_rx_rate
branch
from
August 23, 2024 13:53
4da7814 to
f10dc87
Compare
KanjiMonster
force-pushed
the
jogo_set_rx_rate
branch
from
June 6, 2025 10:02
f10dc87 to
d557d57
Compare
KanjiMonster
force-pushed
the
jogo_set_rx_rate
branch
from
June 6, 2025 12:08
d557d57 to
197e422
Compare
KanjiMonster
force-pushed
the
jogo_set_rx_rate
branch
from
July 25, 2025 11:38
197e422 to
95b56ce
Compare
Update proto to latest HEAD: d81de3cdc5d0 Merge pull request #12 from bisdn/jogo_set_rx_rate 3e4ce8702553 ofdpa.proto: expose ofdpaRxRateSet() Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Since KNET uses a different channel for packets than OpenFlow and is much more efficient, higher packet rates than 1024 (the default) is easily doable. So set the rx rate to unlimited by default when using KNET, but leave it at 1024 pps for TAP. In case this causes issues, add a flag to set a custom limit. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_set_rx_rate
branch
from
July 30, 2025 12:33
95b56ce to
17be6f3
Compare
KanjiMonster
marked this pull request as ready for review
July 30, 2025 12:37
jklare
reviewed
Jul 30, 2025
Comment on lines
+24
to
+28
| # Set a Packets per Seconds rate limit for traffic to controller. | ||
| # -1 = auto (unlimited for KNET, 1024 for TAP) | ||
| # 0 = force unlimited | ||
| # Default is auto. | ||
| # FLAGS_rx_rate_limit=-1 |
Contributor
There was a problem hiding this comment.
How do I set a limit of 1234 ? FLAGS_rx_rate_limit=1234 ?
Contributor
There was a problem hiding this comment.
I mean, by reading the code, I can figure that out, but maybe it would be good to have that as an example here.
Contributor
Author
There was a problem hiding this comment.
There is an implied example ("1024 for TAP"), and the unit is mentioned in the comment above. Is the sentence really that unclear about what is expected here?
Contributor
There was a problem hiding this comment.
yes, i did have to read the code to understand it
jklare
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since KNET uses a different channel for packets than OpenFlow and is much more efficient, higher packet rates than 1024 (the default) is easily doable.
So set the rx rate to unlimited by default when using KNET, but leave it at 1024 pps for TAP.
In case this causes issue, add a flag to set a custom limit.
Description
Motivation and Context
How Has This Been Tested?