Implement KmerTable in Rust#918
Open
padix-key wants to merge 2 commits into
Open
Conversation
Merging this PR will improve performance by 58.36%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuing #688, this PR replaces
KmerTableandBucketKmerTablewith a cleaner and faster Rust implementation.An important changed implementation detail is the layout of the table itself: Previously the it was implemented as table of pointers, where each pointer maps to a separately allocated array. Now all k-mers are part of the same data array and the main table contains the offset to this data array. This avoids millions of allocations and removes the need to store the length of each array, reducing the memory requirements substantially.
Furthermore, a bug is fixed where ignore masks for k-mers from spaced k-mer alphabets are incorrectly applied.