perf(format/html): replace string comparisons with token set checks - #11355
Draft
dyc3 wants to merge 1 commit into
Draft
perf(format/html): replace string comparisons with token set checks#11355dyc3 wants to merge 1 commit into
dyc3 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2235b73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Organic activityNo automation signals detected in the analyzed events. This is an automated analysis by AgentScan |
Merging this PR will degrade performance by 6.45%
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main purpose of this PR was to refactor the HTML formatter to get rid of most string comparisons and related possible memory allocations. However, it turned out there were some bugs, and I just went ahead and fixed those because it made the code more simple.
On my machine, I got a ~1-3% perf improvement
implemented by gpt 5.6 sol
Test Plan
snapshots
Docs