implement _read_indexed and override dims and shape#44
Closed
toloudis wants to merge 2 commits into
Closed
Conversation
kmitcham
approved these changes
Jun 24, 2026
|
|
||
| return self._dims | ||
|
|
||
| def _read_dims_and_shape(self) -> Tuple[Tuple[str, ...], Tuple[int, ...]]: |
Contributor
There was a problem hiding this comment.
Is this reused anywhere? Not sure why it this isn't inline with the caller. I guess it parallels the nd2 read
| dynamic = ["version"] | ||
| dependencies = [ | ||
| "bioio-base>=3.0.0", | ||
| "bioio-base @ git+https://github.com/bioio-devs/bioio-base.git@feat/fast-subslice-reads", |
Contributor
There was a problem hiding this comment.
and this gets cleaned up once the merge happens.
Contributor
|
closing in favor of #51 |
Contributor
Author
okay but why? they look pretty similar |
Contributor
|
I made a mistake in labeling this it is actually #49 that this was closed in favor of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of
_read_indexedfor optimal per-plane reads, and an overriddendimsandshapeproperties. This pr requires the changes in bioio-devs/bioio-base#70 and (temporarily) depends strictly on that branch of bioio-base.