Bugfix/allow remote dest#70
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saeliddp
marked this pull request as ready for review
July 21, 2026 20:49
saeliddp
requested review from
BrianWhitneyAI,
SeanDuHare,
aswallace,
hughes036,
kmitcham,
pgarrison and
toloudis
July 21, 2026 20:49
BrianWhitneyAI
approved these changes
Jul 22, 2026
kmitcham
approved these changes
Jul 22, 2026
BrianWhitneyAI
added a commit
that referenced
this pull request
Jul 24, 2026
Conflicts were in ome_zarr_converter.py between the parallel pool refactor and main's fsspec remote-URI fixes (PR #70). - Kept HEAD's single cross-scene ProcessPoolExecutor and the _plan_and_dispatch_scene / _scene_shard_bounds factoring - Restored main's fsspec-based path building and existence check in convert() so remote URIs (S3, GCS, etc.) are still supported - _plan_and_dispatch_scene now receives an out_path: str consistent with both local and remote path representations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
Follows bioio-devs/bioio-ome-zarr#157 to allow the conversion package to write directly to S3 stores. See related issue: https://github.com/AllenCell/bioio-conversion-pipeline/issues/16
Description of Changes
Replace path building logic that assumed local destinations with logic that allows for remote destinations as well.
Manual Tests