Chore/clean saving folder - #1
Open
kimmchii wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors how audio segments are saved by centralizing and timestamping output directories, and removes redundant package entries.
- Imports
timeto generate timestamped folders. - Moves
segments/root folder creation to module scope. - Creates nested timestamped and per-file directories for segmented audio and updates
split_audiotarget path.
Comments suppressed due to low confidence (1)
app.py:41
- [nitpick] Using
output_wav_name(which includes the.wavextension) for a directory name can be confusing. Consider using the stem (e.g.,Path(output_wav_name).stem) so the folder name doesn’t include the file extension.
segment_audios_folder = current_time_segment_folder / output_wav_name
Comment on lines
+38
to
+42
| os.makedirs(current_time_segment_folder, exist_ok=True) | ||
|
|
||
| # Create folder for segmented audios. | ||
| segment_audios_folder = current_time_segment_folder / output_wav_name | ||
| os.makedirs(segment_audios_folder, exist_ok=True) |
There was a problem hiding this comment.
For consistency with the rest of the codebase using pathlib.Path, you could replace os.makedirs(...) with current_time_segment_folder.mkdir(exist_ok=True, parents=true).
Suggested change
| os.makedirs(current_time_segment_folder, exist_ok=True) | |
| # Create folder for segmented audios. | |
| segment_audios_folder = current_time_segment_folder / output_wav_name | |
| os.makedirs(segment_audios_folder, exist_ok=True) | |
| current_time_segment_folder.mkdir(exist_ok=True, parents=True) | |
| # Create folder for segmented audios. | |
| segment_audios_folder = current_time_segment_folder / output_wav_name | |
| segment_audios_folder.mkdir(exist_ok=True, parents=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txt