Add QR Code Scanner#91
Open
Kore-rep wants to merge 3 commits into
Open
Conversation
Author
|
I now realize the Android App already has deep linking meaning QRs can be used straight from the default camera, feel free to close this if not required |
Contributor
|
@Kore-rep Yeah, I think |
Contributor
|
I think there was some desire to extend the ntfy:// syntax to support configuring a server URL, topic, authentication, and a display name all in a single URL that could be embedded in a QR code. But I agree that we probably don't need to embed a QR code reader in the app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a QR code scanner using Google ML Kit for Android.
The camera is opened via a neutral button on the add subscription button.
The code will be scanned and used to auto-populate the subscription dialog. The text in the codes should have the following format:
ntfy://https://server.com;topicname
Work to consider :
If this work is merged in, I will also update the docs to include a section on QR codes
Built off the work on #67 and #87