feat: Show icon of registered apps and optional message#86
Open
nikclayton wants to merge 1 commit into
Open
Conversation
UnifiedPush allows the end user app to send through an optional message for the distributor to display. Use that, if present (and if the user hasn't set an explicit display name) as the `displayName` for the app. Instead of showing a generic icon for the app, use the app's actual icon. Together, this make it more obvious to the user which app is responsible for a particular registration, and the account (or other metadata) the app is using for the registration. Fixes #1166
Author
|
Before (left), after (right)
|
Author
|
Ping. |
|
@binwiederhier please merge this. |
Owner
|
Oh that's cool. Sorry for the ridiculous delay. If you rebase this, I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnifiedPush allows the end user app to send through an optional message for the distributor to display. Use that, if present (and if the user hasn't set an explicit display name) as the
displayNamefor the app.Instead of showing a generic icon for the app, use the app's actual icon.
Together, this make it more obvious to the user which app is responsible for a particular registration, and the account (or other metadata) the app is using for the registration.
Fixes #1166