WIP: launch activity using broadcast intent#53
Open
wunter8 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This code works for launching an app based on the given package and class, but I only tested it with the |
Owner
Agreed. I do think it has been requested more than once though. But if we do it, we definitely want to do it the right way |
Owner
|
Is this still a valid use case? Has anyone asked for this? |
Contributor
Author
|
It comes up every once in a while. Someone just tried doing it today in binwiederhier/ntfy#1525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think I'm going to finish this. Apparently when you use the
android.intent.action.MAINintent, you have to usectx.startActivityinstead ofctx.sendBroadcast. (See https://developer.android.com/reference/android/content/Intent#standard-activity-actions)So to do it "right", I think we'd need to compare
action.intentto everything in that list of standard activity actions. If it's in the list, usectx.startActivity. If it's not in the list, usectx.sendBroadcast. But at that point, this becomes a much bigger PR and it has only been requested once so far.I'll just leave this code here in case we decide to pick it up again in the future.