Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fixes clipped final row of pokemon entries - #34

Open
beejaymay wants to merge 1 commit into
billyvg:masterfrom
beejaymay:height-fix
Open

Fixes clipped final row of pokemon entries#34
beejaymay wants to merge 1 commit into
billyvg:masterfrom
beejaymay:height-fix

Conversation

@beejaymay

@beejaymay beejaymay commented Aug 25, 2016

Copy link
Copy Markdown

Hard coding calc to account for height of toolbar for now. This is sloppy, and should be made dynamic in the future.

Fixes #33

@ShadOoW

ShadOoW commented Sep 13, 2016

Copy link
Copy Markdown

In HomePage.css

.container {
  height: 100%;
  display: flex;
  flex-direction: column;
}

This should be more maintainable, cheers.

@beejaymay

Copy link
Copy Markdown
Author

Quite right. Thank you.

Note to self: Stop forgetting about flex-box when working on Electron apps. It just works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants