Add support for nested and repeating groups#5
Merged
Conversation
bikeshedder
force-pushed
the
feature/groups
branch
3 times, most recently
from
October 24, 2024 09:21
da4ee7c to
3f0c0ee
Compare
bikeshedder
force-pushed
the
main
branch
2 times, most recently
from
December 10, 2024 22:04
2d5be64 to
0e8b5f0
Compare
astro
reviewed
Mar 13, 2025
bikeshedder
force-pushed
the
feature/groups
branch
3 times, most recently
from
March 13, 2025 20:17
5e71418 to
cb401ad
Compare
Owner
Author
|
It's been quite some time since I last looked into that. I just pushed a working version of the parser. The commit history is a bit messy right now and I'm not 100% happy with the state of the code. I plan on merging it in the next few days though and making a release. I just want to clean-up the code generator a bit which is has turned into a rather unwieldy beast. |
bikeshedder
force-pushed
the
feature/groups
branch
from
March 30, 2026 08:09
5506796 to
f068cdf
Compare
bikeshedder
force-pushed
the
feature/groups
branch
from
March 30, 2026 08:12
f068cdf to
47002fd
Compare
This gets rid of all warnings
bikeshedder
marked this pull request as ready for review
March 30, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #3
It's very much work in progress as the sunspec models currently contain a lot of models with
"count": 0and the code generation is a bit tricky to get right.