fix(frontend): policy row click, Apply config visibility, logs layout density - #250
Merged
Merged
Conversation
bihius
marked this pull request as ready for review
June 24, 2026 04:47
Only the name link opened the policy detail page; the rest of the row was inert despite looking clickable. Wire DataTable's onRowClick to navigate to the policy detail route, keeping the Edit/Delete action buttons working via stopPropagation.
ApplyConfigButton only gated on the admin role, so it stayed visible even when the generated config matched the last applied checksum. Compare generated_config.checksum against latest_reload.config_checksum and render nothing when they match or the runtime status hasn't loaded yet.
The standalone Filters card and the page header together consumed over half of a 1920x1080 viewport before any events were visible. Move the filter controls into a collapsible panel behind a "Filters" toggle next to the Events card title, with a badge showing the active filter count, and reduce the page's vertical spacing.
… filters The null-typed rule_id/min_score filters were miscounted as active by the generic value !== "" check, inflating the Filters badge.
bihius
force-pushed
the
fix/frontend-ux-polish
branch
from
June 24, 2026 05:01
00b09e1 to
47d2a32
Compare
bihius
added a commit
that referenced
this pull request
Jul 3, 2026
fix(frontend): policy row click, Apply config visibility, logs layout density
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stopPropagation.Addresses the frontend UX issues from the policy-row-navigation / Apply-config-visibility / logs-page-density triage (no tracked GitHub issues exist for these yet).
Test plan
pnpm run type-checkandpnpm run lintpasspnpm run test— 83/83 tests pass, including new coverage for the no-pending-changes/not-loaded states and the filters toggle/badge/policies/:id, Logs page header+Events card fit well above the fold, Filters toggle expands/collapses the panel