docs(adr): decide Coraza SPOA integration approach - #162
Merged
Merged
Conversation
Record the M1/MVP decision to use the upstream coraza-spoa sidecar and document the follow-up WAF integration issues it unlocks. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Adds an Architecture Decision Record documenting how Guard Proxy will integrate Coraza with HAProxy for the M1/MVP milestone, and links that decision from the architecture documentation.
Changes:
- Add ADR-007 capturing the decision to use upstream
coraza-spoaas a sidecar service (and why). - Document alternatives (custom Go SPOA, FastAPI/Python-sidecar) with tradeoffs and consequences.
- Reference ADR-007 from
README.architecture.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| notes/decisions/ADR-007-coraza-spoa-integration.md | New ADR describing the selected Coraza SPOA integration approach, rationale, alternatives, and implications. |
| README.architecture.md | Adds ADR-007 to the “Key Decisions” ADR index for discoverability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coraza-spoaas a sidecar for M1/MVP.README.architecture.md.Test plan
git diff --checkCloses #104