feat(dashboard): Show live power flow telemetry - #118
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55d61c47fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bigtomcat6
marked this pull request as ready for review
August 24, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a physical power-flow panel to the Energy Impact page. The panel shows
live power input and output endpoints above the app ranking: the battery
appears as an input while discharging and an output while charging, and
connector labels identify USB-C or MagSafe adapters when recognizable.
Current watts appear only for directly measured hardware values; adapter
ratings and negotiated limits are never shown as live power.
Under the hood this adds power-flow domain rules in Core, a service that
collects and validates live telemetry snapshots, refresh while the page is
visible, safe degradation when power source data is missing, and localized
strings for all supported languages.
How to test
swift test(SwiftPM suites, including newPowerFlowTypesTests,PowerFlowServiceTests,PowerFlowModelTests,PowerFlowViewTests, andlocalization coverage).
power-flow panel renders above the app ranking, battery direction follows
discharge/charge state, connector labels appear when recognizable, and
unavailable values degrade gracefully without crashing. Verify the panel
refreshes while the page stays visible.
Release impact
including battery charge/discharge direction and connector labels when the
adapter can be recognized.
Checklist
type(scope): Summary.Release impact: None.