Skip to content

Prevent floating-point overflow in CalcEffectiveSHR#7

Closed
kevin-moos wants to merge 364 commits into
developfrom
Fix-11261-Floating-point-overflow-in-CalcEffectiveSHR
Closed

Prevent floating-point overflow in CalcEffectiveSHR#7
kevin-moos wants to merge 364 commits into
developfrom
Fix-11261-Floating-point-overflow-in-CalcEffectiveSHR

Conversation

@kevin-moos

Copy link
Copy Markdown

Pull request overview

  • Fixes #ISSUENUMBERHERE

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

Nigusse and others added 30 commits May 5, 2025 11:59
enable later calculation of two setpoint flow request
Matt Mitchell and others added 28 commits October 14, 2025 12:41
…nsition-rule

Remove incorrect transition file
HeatPump:AirToWater followup PR update test idf
Adding GHE borehole field design and sizing
…eports

WSHP coil reports data to eio file without checking for small differences in design size and user specified
…dLoops

Fix space component loads reporting when number of spaces exceeds number of zones
Fix a random error in 3DSlabHT.f90 with gcc 15.2
@kevin-moos kevin-moos closed this Oct 23, 2025
@kevin-moos kevin-moos deleted the Fix-11261-Floating-point-overflow-in-CalcEffectiveSHR branch October 23, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants