ci: add production build steps to all CI jobs - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #122 (astro 7.3.2 + stale
@astrojs/cloudflare) passed CI while both production builds were broken (MISSING_EXPORT: beginContentEntryCollection). CI ran typecheck + tests but never a build, so a broken deploy would only surface at deploy time. This closes that gap.Changes
wrangler deploy --dry-run --outdir dist(existingbuild:ciscript), usingwrangler.toml.examplecopied towrangler.tomlsince the real config is gitignored. Dry-run needs no auth and no real resource IDs.astro buildwithPUBLIC_API_URL=http://localhost:8787(build-time env var, per AGENTS.md).astro build+validate:all(the theme's compliance validators were also missing from CI).Verification
Each new step was run locally in a fresh git worktree (exact CI-equivalent: no gitignored files present):
cp wrangler.toml.example wrangler.toml && npm run build:ci→ exit 0PUBLIC_API_URL=http://localhost:8787 npm run build→ exit 0npm run validate:all+npm run build→ exit 0This PR's own CI run exercises the new steps end-to-end.