Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Feature/countdown timer#134

Open
con322 wants to merge 21 commits into
developfrom
feature/countdown-timer
Open

Feature/countdown timer#134
con322 wants to merge 21 commits into
developfrom
feature/countdown-timer

Conversation

@con322

@con322 con322 commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Countdown timer with options to set date to count down to, background colour or image and a title.
  • Added option to set reveal title, content, and link
  • Added option to hide the timer when finished

@jaymcp jaymcp added this to the v1.2.0 milestone Feb 4, 2019
jaymcp
jaymcp previously requested changes Feb 4, 2019
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/modules/countdown-timer.js Outdated
Comment thread src/scripts/modules/countdown-timer.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/index.js Outdated
Comment thread src/scripts/blocks/countdown-timer/index.js Outdated
@con322 con322 dismissed jaymcp’s stale review February 11, 2019 16:37

code changes

@con322 con322 requested a review from jaymcp February 11, 2019 16:37
jaymcp
jaymcp previously requested changes Feb 12, 2019
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/blocks/countdown-timer/index.js Outdated
Comment thread includes/blocks/countdown-timer/reveal-content.php Outdated
Comment thread includes/blocks/countdown-timer/reveal-content.php Outdated
Comment thread src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated
Comment thread src/scripts/modules/countdown-timer.js Outdated
@con322 con322 dismissed jaymcp’s stale review February 12, 2019 15:36

code changes.

@con322 con322 requested a review from jaymcp February 12, 2019 15:36
jaymcp
jaymcp previously requested changes Feb 13, 2019

@jaymcp jaymcp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry mate 🙈

Comment thread includes/blocks/countdown-timer/reveal-content.php Outdated
Comment thread includes/blocks/countdown-timer/reveal-content.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread includes/blocks/countdown-timer/render.php Outdated
Comment thread src/scripts/modules/countdown-timer.js Outdated
@con322 con322 dismissed jaymcp’s stale review February 13, 2019 14:55

Code review changes.

@con322 con322 requested a review from jaymcp February 13, 2019 14:55

@jaymcp jaymcp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all your hard work on this!

@jaymcp jaymcp added the enhancement New feature or request label Feb 22, 2019
@ampersarnie

Copy link
Copy Markdown
Member

@jonmcp This is 4 years stale, is it still needed?

@jaymcp

jaymcp commented May 9, 2023

Copy link
Copy Markdown
Contributor

@ampersarnie i have no idea

@ampersarnie ampersarnie removed their request for review May 9, 2023 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants