Add 85 automated E. coli SDRF annotations (batch 1) - #51
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (8)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds sandbox status notes for ten datasets, documenting unresolved chemistry normalization or TMT channel-mapping evidence issues and specifying SDRF validation and dataset move-back criteria. ChangesSandbox status documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Normalize free-text modification strings into UNIMOD columns, correct cleavage/instrument/acquisition labels, add ms-proteomics templates, and re-validate all 85 SDRFs. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the TMT-channel and leftover-chemistry cases from datasets/ and park them under sandbox with a note so the PR keeps only the cleaner SDRFs. Co-authored-by: Cursor <cursoragent@cursor.com>
Move each parked dataset to sandbox/<PXD>/ with a per-project notes.md instead of the intermediate ecoli-batch-1-pending folder. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the batch-level notes file now that unresolved datasets have per-project sandbox notes. Co-authored-by: Cursor <cursoragent@cursor.com>
Update technical metadata from one raw file per accession, including tolerances, dissociation method, collision energy, and scan windows. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply one-raw-file technical refinements for batch 2 successes; PXD010126 and PXD013088 failed and were left unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
E. coli SDRF annotations — automated batch 1 (85 datasets)
SDRF-Proteomics annotations for 85 Escherichia coli ProteomeXchange datasets
that were not previously annotated in this repository or
quantms-datasets.How they were produced
submitter sample/data-processing protocols.
characteristics[organism]grounded to the organism PRIDE declares for theproject (single-organism datasets only in this batch).
acquisition method) resolved to PSI-MS accessions against the OLS ontology
cache; any accession that failed verification was reduced to
NT=only.parse_sdrf validate-sdrf -t ms-proteomics(warnings only, noerrors).
Scope / review notes
characteristics[organism part]terms and instrument name casing may warrantrefinement.
raw spectra is a planned follow-up pass.
Summary by CodeRabbit