Skip to content

Show saved profiles in empty terminal panes - #55

Merged
bifrost0x merged 2 commits into
mainfrom
dev/profile-empty-state
Jul 23, 2026
Merged

Show saved profiles in empty terminal panes#55
bifrost0x merged 2 commits into
mainfrom
dev/profile-empty-state

Conversation

@bifrost0x

@bifrost0x bifrost0x commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • show saved connection profiles directly in every empty terminal pane
  • connect immediately for usable SSH-key and currently authorized Tailscale profiles, including key-authenticated jump hosts
  • open the existing pre-filled connection dialog when a target or jump host needs a password, with focus on the missing secret
  • fall back to connection review for stale keys, missing jump hosts, invalid authentication state, or Tailscale policy drift
  • add responsive, keyboard-accessible styling, translations, tests, README documentation, and an updated screenshot

Implements #54

Validation

  • python -m pytest tests -q — 280 passed, 28 skipped
  • npm run test:js — 9 passed
  • node --check on all changed JavaScript files
  • browser QA: single and split layouts, password prefill/focus, and immediate key-profile submission
  • graphify update .
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6666f3c4ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/app.js
Comment on lines +1167 to +1168
if (mode === 'connect' && isSelectedProfileReady(selected)) {
form.requestSubmit();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear save-profile state before auto-launching

When a key/Tailscale profile is in connect mode, this immediately submits the current connection form after selecting the profile. If the user previously left “Save as profile” checked with a profile name, the submit handler will also emit save_profile for this saved profile before connecting, silently creating duplicate/unwanted profiles; if the checkbox is checked but the name is empty, native validation can block the launch instead. Clear or ignore the save-profile fields on this auto-submit path.

Useful? React with 👍 / 👎.

@bifrost0x bifrost0x self-assigned this Jul 23, 2026
@bifrost0x
bifrost0x merged commit 137f198 into main Jul 23, 2026
6 of 7 checks passed
@bifrost0x bifrost0x changed the title Show saved profiles in empty terminal panes Improve profile launches and post-connect commands Jul 23, 2026
@bifrost0x bifrost0x changed the title Improve profile launches and post-connect commands Show saved profiles in empty terminal panes Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant