Show saved profiles in empty terminal panes - #55
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6666f3c4ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (mode === 'connect' && isSelectedProfileReady(selected)) { | ||
| form.requestSubmit(); |
There was a problem hiding this comment.
Clear save-profile state before auto-launching
When a key/Tailscale profile is in connect mode, this immediately submits the current connection form after selecting the profile. If the user previously left “Save as profile” checked with a profile name, the submit handler will also emit save_profile for this saved profile before connecting, silently creating duplicate/unwanted profiles; if the checkbox is checked but the name is empty, native validation can block the launch instead. Clear or ignore the save-profile fields on this auto-submit path.
Useful? React with 👍 / 👎.
Summary
Implements #54
Validation
python -m pytest tests -q— 280 passed, 28 skippednpm run test:js— 9 passednode --checkon all changed JavaScript filesgraphify update .git diff --check