Fix WiX authoring errors blocking Windows MSI release job - #1
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build (Windows MSI)
Fix WiX authoring errors blocking Windows MSI release job
Jul 18, 2026
bhumitschaudhry
marked this pull request as ready for review
July 18, 2026 18:41
There was a problem hiding this comment.
Pull request overview
This PR updates the WiX MSI authoring to resolve Windows release pipeline failures caused by ICE validation errors, aligning the installer with an x64 per-machine install and correcting custom action sequencing.
Changes:
- Marked
INSTALLFOLDERcomponents as 64-bit (Win64="yes") to matchProgramFiles64Folder/Platform="x64"(ICE80). - Added
<CreateFolder />to theINSTALLFOLDERPATH component to satisfy directory keypath/CreateFolders validation (ICE18). - Moved the deferred
RegisterAgentscustom action earlier in the execute sequence to avoid invalid deferred scheduling placement (ICE77).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
133
to
+134
| <!-- Register after files are installed and PATH is set. --> | ||
| <Custom Action="RegisterAgents" After="InstallFinalize">NOT REMOVE</Custom> | ||
| <Custom Action="RegisterAgents" After="InstallFiles">NOT REMOVE</Custom> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build (Windows MSI)failed in release workflows due to WiX ICE validation errors (ICE80,ICE18,ICE77). This PR updates MSI authoring so the installer compiles cleanly on the Windows release pipeline.Align components with 64-bit install target
ProgramFiles64Folderas 64-bit viaWin64="yes":MeleysExecutableMeleysConfigMeleysPathSatisfy directory keypath validation
<CreateFolder />toMeleysPathso theINSTALLFOLDERdirectory/component pair is represented inCreateFolders(resolvesICE18).Correct deferred custom action sequencing
RegisterAgentsfromAfter="InstallFinalize"toAfter="InstallFiles"to keep deferred in-script execution inside the validInstallExecuteSequencewindow (resolvesICE77).