Skip to content

Fix WiX authoring errors blocking Windows MSI release job - #1

Merged
bhumitschaudhry merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Jul 18, 2026
Merged

Fix WiX authoring errors blocking Windows MSI release job#1
bhumitschaudhry merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Build (Windows MSI) failed in release workflows due to WiX ICE validation errors (ICE80, ICE18, ICE77). This PR updates MSI authoring so the installer compiles cleanly on the Windows release pipeline.

  • Align components with 64-bit install target

    • Marked installer components under ProgramFiles64Folder as 64-bit via Win64="yes":
      • MeleysExecutable
      • MeleysConfig
      • MeleysPath
  • Satisfy directory keypath validation

    • Added <CreateFolder /> to MeleysPath so the INSTALLFOLDER directory/component pair is represented in CreateFolders (resolves ICE18).
  • Correct deferred custom action sequencing

    • Moved RegisterAgents from After="InstallFinalize" to After="InstallFiles" to keep deferred in-script execution inside the valid InstallExecuteSequence window (resolves ICE77).
<Component Id="MeleysPath" ... Win64="yes">
  <CreateFolder />
  <Environment Id="MeleysPathEnv" Name="PATH" Value="[INSTALLFOLDER]" ... />
</Component>

<InstallExecuteSequence>
  <Custom Action="RegisterAgents" After="InstallFiles">NOT REMOVE</Custom>
</InstallExecuteSequence>

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build (Windows MSI) Fix WiX authoring errors blocking Windows MSI release job Jul 18, 2026
Copilot AI requested a review from bhumitschaudhry July 18, 2026 18:35
@bhumitschaudhry
bhumitschaudhry marked this pull request as ready for review July 18, 2026 18:41
Copilot AI review requested due to automatic review settings July 18, 2026 18:41
@bhumitschaudhry
bhumitschaudhry merged commit c6153e2 into main Jul 18, 2026
@bhumitschaudhry
bhumitschaudhry deleted the copilot/fix-failing-github-actions-job branch July 18, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WiX MSI authoring to resolve Windows release pipeline failures caused by ICE validation errors, aligning the installer with an x64 per-machine install and correcting custom action sequencing.

Changes:

  • Marked INSTALLFOLDER components as 64-bit (Win64="yes") to match ProgramFiles64Folder / Platform="x64" (ICE80).
  • Added <CreateFolder /> to the INSTALLFOLDER PATH component to satisfy directory keypath/CreateFolders validation (ICE18).
  • Moved the deferred RegisterAgents custom action earlier in the execute sequence to avoid invalid deferred scheduling placement (ICE77).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wix/meleys.wxs
Comment on lines 133 to +134
<!-- Register after files are installed and PATH is set. -->
<Custom Action="RegisterAgents" After="InstallFinalize">NOT REMOVE</Custom>
<Custom Action="RegisterAgents" After="InstallFiles">NOT REMOVE</Custom>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants