Sort skipped healthchecks last in check displays#230
Open
passcod wants to merge 1 commit into
Open
Conversation
Move "skipped" to the end of CHECK_RESULT_ORDER so skipped checks sort after passing ones in the server detail view (and the status snapshot, which shares the same ordering). A skipped check ran no assertion, so it's the least interesting to surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Sort the healthchecks so skipped ones appear at the end of the list.
CHECK_RESULT_ORDERdrives the display sort in the server detail view's checks table (and the status snapshot, which shares the same ordering). Previouslyskippedsat betweenbrokenandpassed; this moves it to the very end, since a skipped check ran no assertion and is the least interesting result to surface. Within each result group checks remain sorted alphabetically.Added Playwright coverage in
health.spec.tsthat seeds failed/passed/skipped checks (with names whose alphabetical order is the reverse of the expected result order) and asserts the rendered vertical order is failed → passed → skipped.