refactor(tamanu): remove unused greenmask command and tamanu alert#503
Open
passcod wants to merge 1 commit into
Open
refactor(tamanu): remove unused greenmask command and tamanu alert#503passcod wants to merge 1 commit into
passcod wants to merge 1 commit into
Conversation
The greenmask config generator is unused. `bestool tamanu alert` was a remnant of an earlier alerting paradigm that has been superseded by the top-level `bestool alertd` daemon, so drop it; `bestool tamanu alertd` stays as an alias to the top-level command. Removes the now-unused `dunce` and `serde_yaml` dependencies (greenmask was their only user). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
passcod
force-pushed
the
remove-greenmask-tamanu-alert
branch
from
9d417d2 to
ceacd3d
Compare
passcod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Removes two things from
bestool tamanu.Stacked on #502 (
tamanu-database-url) — that PR modifiedgreenmask_config.rs, so removing the file is done on top of it to avoid a modify/delete conflict. Base this on #502, not main.Removed
bestool tamanu greenmask_config— the greenmask config generator, unused. Deletes the command and itstamanu-greenmaskfeature (dropped from thetamanuumbrella).bestool tamanu alert— a remnant of an earlier alerting paradigm, superseded by the top-levelbestool alertddaemon.Kept
bestool tamanu alertdstays as a thin alias delegating to the top-levelbestool alertd. The top-level command is unchanged.Knock-on
dunceandserde_yamldependencies — greenmask was their only user.walkdirandbestool-psqlstay (used bybackup_configs/psql/audit_psql).