Temp(?) fix on tzdata hackney's dependency - #1204
Merged
Merged
Conversation
there was a bunch of vulnerabilitie from hackney and tzdata relies on hackney to download latest iana zone info. So we upgraded hackney beyond-all-reason#1191 but that led to beyond-all-reason#1198 So update tzdata to point to an unmerged PR: lau/tzdata#168 that upgrades hackney and changes the code for the new hackney API. This dependency should not stay as is, ideally we can point to hex.pm new version once tzdata has been updated with this fix. This can be tested by firing up a shell: ```elixir Tzdata.DataLoader.download_new() Tzdata.tzdata_version() # 2026b at time of commit ```
geekingfrog
marked this pull request as ready for review
May 28, 2026 08:28
Teifion
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there was a bunch of vulnerabilitie from hackney and tzdata relies on hackney to download latest iana zone info.
So we upgraded hackney #1191 but that led to #1198
So update tzdata to point to an unmerged PR:
lau/tzdata#168
that upgrades hackney and changes the code for the new hackney API. This dependency should not stay as is, ideally we can point to hex.pm new version once tzdata has been updated with this fix.
This can be tested by firing up a shell:
#1198