Tweak many gizmos stress test#8309
Closed
vby wants to merge 2 commits into
Closed
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
james7132
added
C-Examples
james7132
reviewed
Apr 17, 2023
james7132
left a comment
james7132
left a comment
Member
There was a problem hiding this comment.
The variability introduced by this make it difficult to use this as a stress test. Not sure if we should do this.
Contributor
|
This was discussed in the gizmos PR. #6529 (comment) I agree with james in that it makes it difficult to use it as a benchmark. Maybe instead of replacing the "simple" setup, you could add more setups? Replacing |
Author
|
Remove variability if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Make the stress test example
many_gizmosa little bit more fun.Solution
Draw random lines in a cube, seeding by the elapsed seconds.