Skip to content

Add upperCaseFruits assertions, expand array literal matching #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannytheliar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add upperCaseFruits assertions, expand array literal matching #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2120a87
expand array literal test to include all whitespace
dannytheliar Nov 4, 2022
12cfe3f
add upperCaseFruits assertions to handle undefined values
dannytheliar Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ var noForLoops = function(func) {

var noNewArrays = function(func) {
var stringified = func.toString();
it('should not create new arrays', function() {
expect(stringified.includes(('[]' || '[ ]'))).to.equal(false);
it('should not create new array literals', function() {
expect(stringified).not.to.match(/\[\s+\]/);
});
}

Expand Down
7 changes: 7 additions & 0 deletions spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,13 @@
var data = upperCaseFruits(testFruits);
expect(data).to.not.eql(testFruits);
});
it('should return an array of strings', function () {
var data = upperCaseFruits(testFruits);
expect(Array.isArray(data), 'returned value should be an array').to.be.true;
_.each(data, function (fruit) {
expect(fruit).to.be.a('string');
});
});
it('should return an array with all strings converted to uppercase', function () {
var data = upperCaseFruits(testFruits);
var allUpperCase = true;
Expand Down