Skip to content

fix(types): reject bigint typed arrays in encoders - #31

Merged
bytaesu merged 2 commits into
mainfrom
2026-07-25/fix/bigint-typed-array-types
Jul 25, 2026
Merged

fix(types): reject bigint typed arrays in encoders#31
bytaesu merged 2 commits into
mainfrom
2026-07-25/fix/bigint-typed-array-types

Conversation

@bytaesu

@bytaesu bytaesu commented Jul 25, 2026

Copy link
Copy Markdown
Member

Align encoder input types with Uint8Array runtime semantics while preserving BigInt typed arrays for Web Crypto APIs

@bytaesu

bytaesu commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

I'll cut new minor version

@bytaesu
bytaesu marked this pull request as ready for review July 25, 2026 06:12
Copilot AI review requested due to automatic review settings July 25, 2026 06:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Jul 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR aligns encoder input types with their existing runtime behavior.

  • Introduces NumberTypedArray, including Uint8ClampedArray while excluding BigInt typed arrays.
  • Narrows Base32, Base64, hexadecimal, and toUint8Array encoder inputs to number-based typed arrays.
  • Preserves BigInt typed-array support for Web Crypto buffer-source paths.
  • Adds tests and documentation for the revised type contracts.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The narrowed encoder types match the existing numeric conversion behavior, while decoding and Web Crypto paths continue to accept BigInt typed-array views where their runtime APIs support them.

Reviews (1): Last reviewed commit: "Merge branch 'main' into 2026-07-25/fix/..." | Re-trigger Greptile

@bytaesu
bytaesu merged commit c17c58a into main Jul 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants