Removes old CLIP dependency that causes Py3.12 to fail installing - #33
Open
pixelsandpointers wants to merge 1 commit into
Open
Removes old CLIP dependency that causes Py3.12 to fail installing#33pixelsandpointers wants to merge 1 commit into
pixelsandpointers wants to merge 1 commit into
Conversation
This PR updates the dependencies to make sure the package can be installed in recent Python versions which deprecate certain build processes. The CLIP dependency has been replaced with an open source implementation that has feature and API parity.
Member
|
Thanks for the PR! I'm hesitant to merge it since OpenCLIP does not have the exact same weights as "original" CLIP (thus previous experiments on CLIP wouldn't be reproducible). However, please feel free to leave the PR open nonetheless in case others may find it useful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies to make sure the package can be installed in recent Python versions which deprecate certain build processes. The CLIP dependency has been replaced with an open source implementation that has feature and API parity.