Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.10"]
os: [ubuntu-22.04]
runs-on: ${{ matrix.os }}
runs-on: [self-hosted, ml-main]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep untrusted PRs off the self-hosted runner

For PRs from forks or other untrusted contributors, the existing pull_request trigger still runs this workflow, so changing runs-on here means attacker-controlled checkout/build commands like uv sync and Sphinx now execute on ml-main. GitHub's secure-use docs warn that self-hosted runners are not clean ephemeral VMs and can be persistently compromised by untrusted workflow code; keep the PR path on GitHub-hosted runners, gate it to trusted actors, or remove the PR trigger for this self-hosted job.

Useful? React with 👍 / 👎.

steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
Expand Down
Loading