Skip to content

refactor: cleanup debug prints and remove unsafe panics #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
D4ryl00 merged 1 commit into from
Feb 24, 2026
Merged

refactor: cleanup debug prints and remove unsafe panics #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/ble-driver/bridge_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import "C"

import (
"fmt"
"os"
"unsafe"

"go.uber.org/zap"
Expand Down Expand Up @@ -97,7 +98,7 @@ func BLEReceiveFromPeer(remotePID *C.char, payload unsafe.Pointer, length C.int)
//export BLELog
func BLELog(level C.enum_level, message *C.char) { //nolint:revive
if gLogger == nil {
fmt.Println("logger not found")
fmt.Fprintf(os.Stderr, "logger not found\n")
return
}

Expand Down
3 changes: 2 additions & 1 deletion pkg/multipeer-connectivity-driver/driver/cgo_bridge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import "C"

import (
"fmt"
"os"
"unsafe"

"go.uber.org/zap"
Expand Down Expand Up @@ -71,7 +72,7 @@ func MCReceiveFromPeer(remotePID *C.char, payload unsafe.Pointer, length C.int)
//export MCLog
func MCLog(level C.enum_level, message *C.char) { //nolint:golint
if Logger == nil {
fmt.Println("logger not found")
fmt.Fprintf(os.Stderr, "logger not found\n")
return
}

Expand Down
7 changes: 3 additions & 4 deletions pkg/rendezvous/rendezvous.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ func GenerateRendezvousPointForPeriod(topic, seed []byte, date time.Time) []byte
mac := hmac.New(sha256.New, append(topic, seed...))
binary.BigEndian.PutUint64(buf, uint64(date.Unix()))

_, err := mac.Write(buf)
if err != nil {
panic(err)
}
// hash.Hash.Write never returns an error, as documented at
// https://pkg.go.dev/hash#Hash
mac.Write(buf) //nolint:errcheck
sum := mac.Sum(nil)

return sum
Expand Down
Loading