Feature/copilot passthrough p2 - #82
Merged
Merged
Conversation
…r and update initialization logic
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sample applications to reference the local Weasyprint.Wrapped project and refactors the API sample to reuse a DI-managed Printer that is initialized once at startup, while also aligning README instructions with current script names.
Changes:
- Replaced NuGet package references in sample apps with local
ProjectReferences. - Refactored
ExampleApito inject a singletonPrinterand initialize it once during app startup. - Updated README to reference
build-on-linux.shand adjusted sample-running guidance.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Weasyprint.Wrapped.ExampleApi/Weasyprint.Wrapped.ExampleApi.csproj | Switches API sample from package reference to project reference. |
| src/Weasyprint.Wrapped.ExampleApi/Program.cs | Registers Printer as a singleton and initializes it at startup. |
| src/Weasyprint.Wrapped.ExampleApi/Controllers/PrintController.cs | Fixes logger generic type and injects/reuses DI-managed Printer. |
| src/Weasyprint.Wrapped.Example/Weasyprint.Wrapped.Example.csproj | Switches console sample from package reference to project reference. |
| readme.md | Updates Linux build script name and revises sample-running instructions. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…i.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
berthertogen
enabled auto-merge
April 18, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80