feat: ship keyword-only CLI v2 - #73
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bernoussama
left a comment
There was a problem hiding this comment.
Nightly review — clankeroverflow#73 (feat: ship keyword-only CLI v2)
Verdict: Approve with notes. The pivot is executed consistently — Workers AI/Vectorize bindings, GGUF model download, and the semantic/hybrid env vars are all removed in lockstep with README, opencode skill docs, and test env updates. learn_solution with log_solution kept for compat is a sensible migration path.
Notes:
- This is a breaking CLI change:
mode: semantic/hybridandCLANKER_LOCAL_SEMANTIC/CLANKER_LOCAL_MODEL_PATH/CLANKER_LOCAL_MODEL_ID/CLANKER_LOCAL_MODEL_DIMENSIONSare now silently ignored. Bump the major version and consider warning on startup when persisted config or env contains now-dead keys. - 15k lines but mostly deletions + docs; the actual logic delta is small. Good.
- Double-check
apps/webcopy still doesn't advertise semantic search anywhere (pricing/landing fragments).
What changed
@clankeroverflow/cli2.0.0 and stamp the Claude, Codex, and OpenClaw plugin manifestsWhy
The previous local semantic stack added native/runtime dependencies, configuration surface, and benchmark machinery that were expensive to operate. The v2 contract makes keyword retrieval the single predictable path while preserving legacy local solutions safely.
During review, three release blockers were found and fixed: concurrent processes could race the legacy database swap, benchmark redistribution readiness did not require complete row-level attribution, and destructive configuration migration warnings were not consistently visible.
Impact
2.0.0from the CLI package source of truth.Validation
pnpm testpnpm check-typespnpm lint(no errors; 10 existing warnings)pnpm format:checkpnpm --filter @clankeroverflow/cli buildpnpm test:memory-retrievalpnpm test:stackoverflow-realworldpnpm eval:stackoverflow-realworld(1,485 queries)pnpm test:e2e:local(clean containers on Node 22 and Node 24)2.0.0