run workflows when they themselves change - #32
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates deployment/release workflow path filters so each workflow runs when its own workflow file changes.
Changes:
- Added
.github/workflows/release-cli.ymlto the Release CLI workflow push paths. - Added
.github/workflows/cd.ymlto the CD workflow push paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release-cli.yml |
Triggers CLI release workflow when its workflow definition changes. |
.github/workflows/cd.yml |
Triggers CD workflow when its workflow definition changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d50119cd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - master | ||
| paths: | ||
| - "packages/cli/**" | ||
| - ".github/workflows/release-cli.yml" |
There was a problem hiding this comment.
When a push changes only this workflow, the new path filter now starts the full release pipeline even though packages/cli/package.json:3 still contains the previously released version. The publish job is unconditional after validation and runs pnpm publish at .github/workflows/release-cli.yml:90; npm documents that once a name/version pair is published, it can never be used again. Consequently, ordinary workflow-only maintenance pushes fail while trying to republish the existing CLI version instead of merely validating the workflow. Gate the publish job on a packages/cli/** change or split workflow validation from release publication.
Useful? React with 👍 / 👎.
No description provided.