Refactor - #19
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ad9bf4ecf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const inter = Inter({ | ||
| variable: "--font-sans", | ||
| subsets: ["latin"], | ||
| }); | ||
|
|
||
| const geistMono = Geist_Mono({ | ||
| variable: "--font-geist-mono", | ||
| const jetbrainsMono = JetBrains_Mono({ | ||
| variable: "--font-mono", | ||
| subsets: ["latin"], |
There was a problem hiding this comment.
Avoid self-referential font variables
With Next's font classes on <body>, --font-sans and --font-mono are set to values that include var(--font-sans)/var(--font-mono), which makes those custom properties invalid at computed-value time. Any page using the new font-sans, font-mono, font-body-md, font-code-sm, or font-label-caps classes will therefore fall back to browser fonts instead of the loaded Inter/JetBrains faces. Use distinct Next font variable names (as before, e.g. --font-inter/--font-jetbrains) and reference those from Tailwind/theme utilities.
Useful? React with 👍 / 👎.
This pull request significantly expands and clarifies the documentation for creating Claude Code slash commands. The updates provide more comprehensive guidance, practical examples, and troubleshooting steps for both new and advanced users. The changes improve the structure and readability of both the core skill documentation (
SKILL.md) and the reference guide (README.md), making it easier to understand command fundamentals, advanced patterns, and plugin integrations.Documentation enhancements:
README.mdandSKILL.md. [1] [2] [3] [4]Plugin and advanced command patterns:
${CLAUDE_PLUGIN_ROOT}, plugin resource referencing, and namespace conventions for plugin commands. [1] [2] [3] [4]Troubleshooting and maintenance:
Status, versioning, and workflow documentation:
Formatting and clarity improvements:
These updates make the documentation more actionable and user-friendly for both new and experienced users working with Claude Code slash commands.