Skip to content

Add bbop-manager-golr package#26

Merged
pkalita-lbl merged 2 commits into
mainfrom
issue-13-bbop-manager-golr
May 5, 2026
Merged

Add bbop-manager-golr package#26
pkalita-lbl merged 2 commits into
mainfrom
issue-13-bbop-manager-golr

Conversation

@pkalita-lbl

Copy link
Copy Markdown
Member

Fixes #13

These changes bring in the source code for bbop-manager-golr into a new workspace package. The original repo had a lot of infrastructure for spinning up local Solr instances but the configurations were quite outdate, and there was no process to keep them updated (as noted in berkeleybop/bbop-manager-golr#7). In the interest of simplifying things those tests are not being carried forward. The basic functional tests (which do not rely on running services -- local or remote) are retained.

These changes also bring in golr-conf as a workspace package. golr-conf is intended to be used in conjunction with bbop-manager-golr, and golr-conf depends on bbop-core. Therefore it makes sense to develop golr-conf in this monorepo.

Finally, the tests for both bbop-manager-golr and golr-conf previously relied on data from the amigo2 package. That package is probably a candidate for deprecation. In preparation for that the necessary data has been extracted from it and inlined as test fixtures.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the legacy bbop-manager-golr code into the monorepo, adds the companion golr-conf workspace package, and replaces old external test data with in-repo fixtures so both packages fit the monorepo’s current packaging/test pattern.

Changes:

  • Adds a new golr-conf package with config wrappers, fixtures, tests, README, and package metadata.
  • Adds a new bbop-manager-golr package with GOlr query/state management logic, fixtures, tests, README, and package metadata.
  • Updates the root lockfile to register both new workspace packages.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/golr-conf/src/fixtures/golr-config.js Adds inlined GOlr config fixture data used by tests.
packages/golr-conf/src/conf.test.js Adds tests for config field/class/top-level wrapper behavior.
packages/golr-conf/src/conf.js Adds the golr-conf runtime API for wrapping GOlr config data.
packages/golr-conf/README.md Adds package overview and availability links.
packages/golr-conf/package.json Adds package metadata, scripts, exports, and dependencies.
packages/bbop-manager-golr/src/manager.test.js Adds functional tests for query building, state handling, paging, batching, and serialization.
packages/bbop-manager-golr/src/manager.js Adds the GOlr manager implementation for URL building, callbacks, state, and downloads.
packages/bbop-manager-golr/src/fixtures/golr-config.js Adds a focused fixture used by manager tests.
packages/bbop-manager-golr/README.md Adds package overview and availability links.
packages/bbop-manager-golr/package.json Adds package metadata, scripts, exports, and dependencies.
package-lock.json Registers the new workspace packages in the lockfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/bbop-manager-golr/src/manager.js
Comment thread packages/bbop-manager-golr/src/manager.js
Comment thread packages/bbop-manager-golr/src/manager.js
Comment thread packages/bbop-manager-golr/src/manager.js
Comment thread packages/bbop-manager-golr/src/manager.js
Comment thread packages/bbop-manager-golr/src/manager.js
@pkalita-lbl
pkalita-lbl merged commit 74f49e2 into main May 5, 2026
5 checks passed
@pkalita-lbl
pkalita-lbl deleted the issue-13-bbop-manager-golr branch May 5, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move bbop-manager-golr source into monorepo

2 participants