Add bbop-manager-golr package#26
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the legacy bbop-manager-golr code into the monorepo, adds the companion golr-conf workspace package, and replaces old external test data with in-repo fixtures so both packages fit the monorepo’s current packaging/test pattern.
Changes:
- Adds a new
golr-confpackage with config wrappers, fixtures, tests, README, and package metadata. - Adds a new
bbop-manager-golrpackage with GOlr query/state management logic, fixtures, tests, README, and package metadata. - Updates the root lockfile to register both new workspace packages.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
packages/golr-conf/src/fixtures/golr-config.js |
Adds inlined GOlr config fixture data used by tests. |
packages/golr-conf/src/conf.test.js |
Adds tests for config field/class/top-level wrapper behavior. |
packages/golr-conf/src/conf.js |
Adds the golr-conf runtime API for wrapping GOlr config data. |
packages/golr-conf/README.md |
Adds package overview and availability links. |
packages/golr-conf/package.json |
Adds package metadata, scripts, exports, and dependencies. |
packages/bbop-manager-golr/src/manager.test.js |
Adds functional tests for query building, state handling, paging, batching, and serialization. |
packages/bbop-manager-golr/src/manager.js |
Adds the GOlr manager implementation for URL building, callbacks, state, and downloads. |
packages/bbop-manager-golr/src/fixtures/golr-config.js |
Adds a focused fixture used by manager tests. |
packages/bbop-manager-golr/README.md |
Adds package overview and availability links. |
packages/bbop-manager-golr/package.json |
Adds package metadata, scripts, exports, and dependencies. |
package-lock.json |
Registers the new workspace packages in the lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
These changes bring in the source code for
bbop-manager-golrinto a new workspace package. The original repo had a lot of infrastructure for spinning up local Solr instances but the configurations were quite outdate, and there was no process to keep them updated (as noted in berkeleybop/bbop-manager-golr#7). In the interest of simplifying things those tests are not being carried forward. The basic functional tests (which do not rely on running services -- local or remote) are retained.These changes also bring in
golr-confas a workspace package.golr-confis intended to be used in conjunction withbbop-manager-golr, andgolr-confdepends onbbop-core. Therefore it makes sense to developgolr-confin this monorepo.Finally, the tests for both
bbop-manager-golrandgolr-confpreviously relied on data from theamigo2package. That package is probably a candidate for deprecation. In preparation for that the necessary data has been extracted from it and inlined as test fixtures.