Skip to content

fix(nx-knip): support knip 6 #51

Description

@christopher-buss

Problem

@berenddeboer/nx-knip declares knip: ^5.0.0 as a required peer dependency. Consumers using Knip 6 receive a peer-dependency incompatibility even though the executor invokes the same documented knip --workspace CLI surface.

The compatibility claim should be based on the packaged plugin running against concrete dependency versions, not only on unit tests with a mocked subprocess.

Proposed verification

Exercise the built nx-knip package against this Knip matrix:

  • 5.0.0, the oldest currently supported release
  • 5.88.1, the latest Knip 5 release
  • 6.35.1, the latest Knip 6 release

If all three install and execute successfully, widen the peer dependency to ^5.0.0 || ^6.0.0. Keep Nx 23 support out of scope; that is tracked separately in #42.

Acceptance criteria

  • A packaged-executor compatibility check runs with Knip 5.0.0, latest Knip 5, and latest Knip 6.
  • The check verifies the nx-knip executor invokes the installed Knip successfully.
  • The peer range includes Knip 6 only when the matrix passes.
  • Existing nx-knip lint, tests, and build remain green.

Generated with Codex.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions