Repository navigation
Fix crash opening recent checks saved before product links - #40
Merged
Merged
Conversation
Stored results from before PR #39 carry offers without productLink, and ChemicalCard dereferenced it unconditionally, taking the page down. The card now renders the link only when present, and parseHistory backfills the Kenya search link from brand and pack so old checks keep working links. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #39: checks stored in localStorage before product links shipped carry offers without productLink, and ChemicalCard dereferenced offer.productLink.url unconditionally - reopening such a recent check crashed the page ('This page could not load'). Fix is two-layer: the card renders the link only when present, and parseHistory backfills the Kenya search link from brand and pack so legacy checks keep working links. Regression test covers a pre-link stored entry. 274/274 tests, lint/tsc/build clean.